Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max client disconnect docs #12467

Merged

Conversation

mikenomitch
Copy link
Contributor

No description provided.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor touch-ups.

website/content/docs/job-specification/group.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/group.mdx Outdated Show resolved Hide resolved
@tgross
Copy link
Member

tgross commented Apr 5, 2022

Does this close #12448 ?

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

website/content/docs/job-specification/group.mdx Outdated Show resolved Hide resolved
@mikenomitch
Copy link
Contributor Author

Committed all the suggestions. Thanks.

I think it closes #12448 unless yall had something else in mind. We have the Edge Learn guide coming soon for in depth stuff too fwiw.

@tgross tgross changed the base branch from f-disconnected-client-allocation-handling to main April 6, 2022 12:29
@tgross tgross changed the base branch from main to f-disconnected-client-allocation-handling April 6, 2022 12:29
Co-authored-by: Derek Strickland <1111455+DerekStrickland@users.noreply.github.com>
@tgross
Copy link
Member

tgross commented Apr 6, 2022

Rebased on the feature branch.

@tgross
Copy link
Member

tgross commented Apr 6, 2022

@tgross tgross merged commit 8493730 into f-disconnected-client-allocation-handling Apr 6, 2022
@tgross tgross deleted the docs-disconnected-clients branch April 6, 2022 12:54
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants