Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add os to NodeListStub struct. #12497

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Add os to NodeListStub struct. #12497

merged 3 commits into from
Apr 16, 2022

Conversation

shishir-a412ed
Copy link
Contributor

@shishir-a412ed shishir-a412ed commented Apr 7, 2022 •
edited

ping @tgross @DerekStrickland

Signed-off-by: Shishir Mahajan smahajan@roblox.com

@shishir-a412ed shishir-a412ed mentioned this pull request Apr 7, 2022
Merged
schmichael
schmichael requested changes Apr 13, 2022
View reviewed changes
nomad/structs/structs.go Outdated Show resolved Hide resolved
nomad/structs/structs.go Outdated Show resolved Hide resolved
api/nodes.go Outdated Show resolved Hide resolved
@shishir-a412ed
Copy link
Contributor Author

@schmichael PTAL.

schmichael
schmichael approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Going to hold off merging until we can get a test in place.

@shishir-a412ed
Add os to NodeListStub struct.
e36f44f 
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
@shishir-a412ed
Add os as a query param to /v1/nodes.
07d47a3 
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
@shishir-a412ed
Add test: os as a query param to /v1/nodes.
32a6f0b 
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
@shishir-a412ed
Copy link
Contributor Author

@schmichael Added test. PTAL.

@vercel vercel bot temporarily deployed to Preview – nomad April 15, 2022 23:15 Inactive
@schmichael schmichael merged commit c86642b into hashicorp:main Apr 16, 2022
@schmichael
Copy link
Member

Thanks @shishir-a412ed!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shishir-a412ed @schmichael