Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Disconnected Clients: "Unknown" allocations in the UI #12544
[ui] Disconnected Clients: "Unknown" allocations in the UI #12544
Changes from 11 commits
3fcff4c
24ce5f8
0fd2b7e
8101e06
dc6a463
25c57c6
8db1b19
4aadf31
6377f93
7f40945
44d0fd5
2daa06c
9f8ae31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change (and similar changes to jobs/job/allocations controller, etc.) all correspond to these filters:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this rule:
![image](https://user-images.githubusercontent.com/713991/162802506-4692d3b8-ef3b-4ef4-940c-8abef72922f5.png)
With this rule:
![image](https://user-images.githubusercontent.com/713991/162802547-b280af52-4b49-4a6a-bad5-52b50ff25a58.png)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should this impact all jobs?
In the edge case, we're developing this feature to enable those users to maintain their up-time requirements. That makes me feel like this situation is only regarding
service
jobs which are long-standing jobs compared tosystem
andbatch
jobs.cc: @DerekStrickland @mikenomitch do I have this to be, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System, sysbatch, service and batch jobs can all transition to unknown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah all of them can be unknown.
Not important for the code, but actually in some ways batch is more vital than service. Since batch jobs are "stateful" more often that service, the cost of restarting them can often be higher. So losing connection and coming back gracefully is more important.