Commits on Apr 12, 2022

1. CSI: fix data race in plugin manager …

   The plugin manager for CSI hands out instances of a plugin for callers
   that need to mount a volume. The `MounterForPlugin` method accesses
   the internal instances map without a lock, and can be called
   concurrently from outside the plugin manager's main run-loop.
   
   The original commit for the instances map included a warning that it
   needed to be accessed only from the main loop but that comment was
   unfortunately ignored shortly thereafter, so this bug has existed in
   the code for a couple years without being detected until we ran tests
   with `-race` in #12098. Lesson learned here: comments make for lousy
   enforcement of invariants!

   

   tgross committed Apr 12, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 762acf8
   • Browse repository at this point

   Copy the full SHA

   762acf8 View commit details

   Browse the repository at this point in the history