Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data race in dynamic plugin registry tests #12554

Merged
merged 2 commits into from
Apr 14, 2022
Merged

fix data race in dynamic plugin registry tests #12554

merged 2 commits into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. fix data race in dynamic plugin registry tests 

    These tests have a data race where the test assertion is reading a
value that's being set in the `listenFunc` goroutines that are
subscribing to registry update events. Move the assertion into the
subscribing goroutine to remove the race. This bug was discovered
in #12098 but does not impact production Nomad code.
    @tgross
    tgross committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f30e8a8 View commit details
    Browse the repository at this point in the history

  2. address comments from code review

    @tgross
    tgross committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    ae1b029 View commit details
    Browse the repository at this point in the history