Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation resources returned in a struct #1260

Merged
merged 3 commits into from
Jun 12, 2016
Merged

Allocation resources returned in a struct #1260

merged 3 commits into from
Jun 12, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Jun 12, 2016 •
edited

This PR:

  • Makes allocation stats be returned in a struct. This allows us to do a roll up by tasks and eventually add disk usage to the allocation.
  • Does not return a latest resource if the task is dead. This causes the rolled up resources to be incorrect.
  • Remove since command and only report latest

@dadgar dadgar mentioned this pull request Jun 12, 2016
Merged
diptanu
diptanu reviewed Jun 12, 2016
View reviewed changes
client/alloc_runner.go
func (r *AllocRunner) AllocStats() map[string]TaskStatsReporter {
// LatestAllocStats returns the latest allocation stats. If the optional taskFilter is set
// the allocation stats will only include the given task.
func (r *AllocRunner) LatestAllocStats(taskFilter string) (*cstructs.AllocResourceUsage, error) {
Copy link
Contributor

@diptanu diptanu Jun 12, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadgar I think we should keep the StatsReporter interface, so that we can add methods around histograms etc, otherwise we will have to add those methods in the client as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dadgar dadgar merged commit 591104f into master Jun 12, 2016
@dadgar dadgar deleted the f-alloc-stats-struct branch June 12, 2016 18:18
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dadgar @diptanu