Backport of Fix health checking for ephemeral poststart tasks into release/1.1.x #12615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #11945 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
The below text is copied from the body of the original PR.
This PR updates the logic in the Nomad client's alloc health tracker which
erroneously marks existing healthy allocations with dead poststart ephemeral
tasks as unhealthy even if they were already successful during a previous
deployment. For repro see: #10058 (comment)
Currently, users are having to insert sleep after short-lived ephemeral tasks.
This change ensures that poststart lifecycle tasks which have succeeded,
even before 'min_healthy_time', will not result in the whole allocation being
marked as unhealthy.
I've attempted to include test coverage that sticks to your existing conventions.
which have already succeeded with any running duration.
Fixes #9254
Fixes #10058