Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix health checking for ephemeral poststart tasks into release/1.1.x #12615

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #11945 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

The below text is copied from the body of the original PR.


This PR updates the logic in the Nomad client's alloc health tracker which
erroneously marks existing healthy allocations with dead poststart ephemeral
tasks as unhealthy even if they were already successful during a previous
deployment. For repro see: #10058 (comment)

Currently, users are having to insert sleep after short-lived ephemeral tasks.
This change ensures that poststart lifecycle tasks which have succeeded,
even before 'min_healthy_time', will not result in the whole allocation being
marked as unhealthy.

I've attempted to include test coverage that sticks to your existing conventions.

  • Tracker will not attempt to evaluate the health of poststart ephemeral tasks
    which have already succeeded with any running duration.
  • Add a mock and helper for deployments of allocations with poststart tasks

Fixes #9254
Fixes #10058

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-post-start-tasks/intensely-crisp-eft branch from 6100cf9 to 70b55fc Compare April 19, 2022 14:47
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 81ea06f into release/1.1.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/fix-post-start-tasks/intensely-crisp-eft branch April 19, 2022 14:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants