Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix mTLS certificate check on agent to agent RPCs into release/1.2.x #12626

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #11998 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


PR #11956 implemented a new mTLS RPC check to validate the role of the
certificate used in the request, but further testing revealed two flaws:

  1. client-only endpoints did not accept server certificates so the
    request would fail when forwarded from one server to another.
  2. the certificate was being checked after the request was forwarded,
    so the check would happen over the server certificate, not the
    actual source.

This PR checks for the desired mTLS level, where the client level
accepts both, a server or a client certificate. It also validates the
cercertificate before the request is forwarded.

#11956 was never released, so no CHANGELOG needed.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-rpc-tls-certificate-check/admittedly-precise-anteater branch from 50b7d2f to 344bb90 Compare April 19, 2022 17:29
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit b0f8b18 into release/1.2.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/fix-rpc-tls-certificate-check/admittedly-precise-anteater branch April 19, 2022 17:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants