Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: minor refactoring into release/1.2.x #12641

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12105 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


While working on #8609 I ended up having two minor refactors, which I want to keep out of the PR for that bug because it'll make it harder to review:

  • Rename the method (*CSIVolume) WriteFreeClaims to HasFreeWriteClaims
  • Use package-level variables for some of the errors we return from (*CSIVolume) Claim
  • Made semgrep happy about our testify usage after the two changes above

Marking this as needing backports because the backported patches for #8609 will be built on this code as well.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/csi-minor-refactor/kindly-touching-thrush branch from e21b430 to 684f130 Compare April 19, 2022 17:46
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 410ea59 into release/1.2.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/csi-minor-refactor/kindly-touching-thrush branch April 19, 2022 17:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants