Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: enforce usage at claim time into release/1.2.x #12648

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12112 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


When the scheduler checks feasibility for CSI volumes, the check is
fairly loose: earlier versions of the same job are not counted as
active claims. This allows the scheduler to place new allocations
for the new version of a job, under the assumption that we'll replace
the existing allocations and their volume claims.

But when the alloc runner claims the volume, we need to enforce the
active claims even if they're for allocations of an earlier version of
the job. Otherwise we'll try to mount a volume that's currently being
unmounted, and this will cause replacement allocations to frequently
fail.

This changeset corrects this behavior for both write claims and read
claims. I've broken it across a small set of commits for clarity.


Partial fix for #8609 but will also require #12113 to handle this scenario gracefully on the client.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/csi-enforce-usage-at-claim-time/specially-simple-swine branch from 2112643 to 6750d5a Compare April 19, 2022 17:51
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 60839d2 into release/1.2.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/csi-enforce-usage-at-claim-time/specially-simple-swine branch April 19, 2022 17:51
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants