Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix CSI volume list with prefix and * namespace into release/1.1.x #12673

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12184 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

The below text is copied from the body of the original PR.


When using a prefix value and the * wildcard for namespace, the endpoint
would not take the prefix value into consideration due to the order in
which the checks were executed but also the logic for retrieving volumes
from the state store.

This commit changes the order to check for a prefix first and wraps the
result iterator of the state store query in a filter to apply the
prefix.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-csi-volume-list-prefix/seemingly-prepared-bluejay branch from 6ecce26 to 507afd4 Compare April 19, 2022 18:35
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 7d6f90b into release/1.1.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/fix-csi-volume-list-prefix/seemingly-prepared-bluejay branch April 19, 2022 18:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants