Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: handle per-alloc volumes in alloc status -verbose CLI into release/1.1.x #12704

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12573 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

The below text is copied from the body of the original PR.


While walking @philrenaud thru #11965 I realized that we have the exact same problem in the CLI. 🤦

The Nomad client's csi_hook interpolates the alloc suffix with the
volume request's name for CSI volumes with per_alloc = true, turning
example into example[1]. We need to do this same behavior in the
alloc status output so that we show the correct volume.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-csi-cli-alloc-status/recently-equal-glowworm branch from 4e28fa2 to 07f0b93 Compare April 20, 2022 00:50
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit c8b710c into release/1.1.x Apr 20, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-csi-cli-alloc-status/recently-equal-glowworm branch April 20, 2022 00:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants