-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui, bugfix] Link fix for volumes where per_alloc=true #12713
Changes from 5 commits
3926584
f16fdc5
ffc2d4c
190370d
633b877
0ebdeb6
f1ee4bd
78c7282
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -293,12 +293,17 @@ | |
<tr data-test-volume> | ||
<td data-test-volume-name> | ||
{{#if row.model.isCSI}} | ||
<LinkTo | ||
@route="csi.volumes.volume" | ||
@model={{concat row.model.source "@" row.model.namespace.id}} | ||
> | ||
{{row.model.name}} | ||
</LinkTo> | ||
{{!-- if volume is per_alloc=true, there's no one specific volume. So, link to the volumes index with an active query --}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. This seems like the best we can do here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably unrelated to this PR, but on one attempt to click this link the back button broke and I couldn't get back to this page. Unfortunately it only happened once and I can't reproduce it anymore. |
||
{{#if row.model.perAlloc}} | ||
<LinkTo @route="csi.volumes.index" @query={{hash search=row.model.source}}>{{row.model.name}}</LinkTo> | ||
{{else}} | ||
<LinkTo | ||
@route="csi.volumes.volume" | ||
@model={{concat row.model.source "@" row.model.namespace.id}} | ||
> | ||
{{row.model.name}} | ||
</LinkTo> | ||
{{/if}} | ||
{{else}} | ||
{{row.model.name}} | ||
{{/if}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise:
great job! This is such a simple, elegant solution.