Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: plugin supervisor prestart should not mark itself done #12752

Merged
merged 2 commits into from
Apr 22, 2022
Merged

CSI: plugin supervisor prestart should not mark itself done #12752

merged 2 commits into from
Apr 22, 2022

Commits on Apr 22, 2022

  1. CSI: plugin supervisor prestart should not mark itself done 

    The task runner hook `Prestart` response object includes a `Done`
field that's intended to tell the client not to run the hook
again. The plugin supervisor creates mount points for the task during
prestart and saves these mounts in the hook resources. But if a client
restarts the hook resources will not be populated. If the plugin task
restarts at any time after the client restarts, it will fail to have
the correct mounts and crash loop until restart attempts run out.

Fix this by not returning `Done` in the response, just as we do for
the `volume_mount_hook`.
    @tgross
    tgross committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    a6d530a View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @tgross
    tgross committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    30ece42 View commit details
    Browse the repository at this point in the history