Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against restoring a nil task in task_runner #1294

Merged
merged 1 commit into from
Jun 16, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/task_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,13 @@ func (r *TaskRunner) RestoreState() error {
}

// Restore fields
r.task = snap.Task
if snap.Task == nil {
err := fmt.Errorf("task runner snapshot include nil Task")
r.logger.Printf("[ERR] client: %v", err)
return err
} else {
r.task = snap.Task
}
r.artifactsDownloaded = snap.ArtifactDownloaded

if err := r.setTaskEnv(); err != nil {
Expand Down