Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: allow stale namespace results #12953

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Commits on Aug 26, 2022

  1. consul: allow stale namespace results

    Nomad reconciles services it expects to be registered in Consul with
    what is actually registered in the local Consul agent. This is necessary
    to prevent leaking service registrations if Nomad crashes at certain
    points (or if there are bugs).
    
    When Consul has namespaces enabled, we must iterate over each available
    namespace to be sure no services were leaked into non-default
    namespaces.
    
    Since this reconciliation happens often, there's no need to require
    results from the Consul leader server. In large clusters this creates
    far more load than the "freshness" of the response is worth.
    
    Therefore this patch switches the request to AllowStale=true
    schmichael committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    f298877 View commit details
    Browse the repository at this point in the history