Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update max_stale to match consul and update docs to match new value #13052

Closed
wants to merge 1 commit into from

Conversation

chuckyz
Copy link
Contributor

@chuckyz chuckyz commented May 17, 2022

This matches Consul's current default (set in 0.7.1)

@mikenomitch
Copy link
Contributor

@DerekStrickland pinging you on this since it seems related to #13041

@chuckyz
Copy link
Contributor Author

chuckyz commented May 18, 2022

Well heck looks like Derek has me thoroughly trounced on this one! I'll just make it the doc update if you'd like @mikenomitch (I can do the doc updates from #13041 too if you'd like)

@DerekStrickland
Copy link
Contributor

Thanks @chuckyz I missed removing this variable. I'll get this stuff ported into #13041.

@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation May 31, 2022
@tgross
Copy link
Member

tgross commented Jun 6, 2022

@DerekStrickland safe to close this in lieu of #13041?

@DerekStrickland
Copy link
Contributor

@tgross Yes. Doing that now.

Nomad - Community Issues Triage automation moved this from Needs Triage to Done Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants