Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix Exec not working with reverse proxy X-Nomad-Token into release/1.1.x #13251

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12925 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This fixes an issue with Exec feature not working when a reverse proxy is used to automatically inject X-Nomad-Token.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-exec-reverse-proxy/strangely-prime-dingo branch from d4dd0fd to 25c5916 Compare June 6, 2022 17:36
@lgfa29 lgfa29 requested review from lgfa29 and removed request for philrenaud June 6, 2022 17:39
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Ember Asset Size action

As of 873cf0c

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +29 B +13 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

* Capture token secret on fetch

* Fix tests

* Fix lint errors
@lgfa29 lgfa29 force-pushed the backport/fix-exec-reverse-proxy/strangely-prime-dingo branch from 25c5916 to 873cf0c Compare June 6, 2022 18:37
@lgfa29 lgfa29 merged commit 7e11112 into release/1.1.x Jun 6, 2022
@lgfa29 lgfa29 deleted the backport/fix-exec-reverse-proxy/strangely-prime-dingo branch June 6, 2022 18:52
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Ember Test Audit comparison

release/1.1.x 873cf0c change
passes 1135 1135 0
failures 0 0 0
flaky 0 0 0
duration 8m 21s 913ms 9m 34s 020ms +1m 12s 107ms

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants