Commits on Jun 7, 2022

1. CSI: no early return when feasibility check fails on eligible nodes …

   As a performance optimization in the scheduler, feasibility checks
   that apply to an entire class are only checked once for all nodes of
   that class. Other feasibility checks are "available" checks because
   they rely on more ephemeral characteristics and don't contribute to
   the hash for the node class. This currently includes only CSI.
   
   We have a separate fast path for "available" checks when the node has
   already been marked eligible on the basis of class. This fast path has
   a bug where it returns early rather than continuing the loop. This
   causes the entire task group to be rejected.
   
   Fix the bug by not returning early in the fast path and instead jump
   to the top of the loop like all the other code paths in this method.
   Includes a new test exercising topology at whole-scheduler level and a
   fix for an existing test that should've caught this previously.

   

   tgross committed Jun 7, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 41744a6
   • Browse repository at this point

   Copy the full SHA

   41744a6 View commit details

   Browse the repository at this point in the history