-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement RPC rate limiting #13480
base: main
Are you sure you want to change the base?
implement RPC rate limiting #13480
Conversation
Provide a facility for pre-auth rate limiting at the Nomad servers, with the ability to observe which users are creating the load.
Add helper functions to each RPC endpoint so that the endpoint configuration doesn't need to be repeated for individual handlers, and to extract node ID where needed.
Nothing that a lot of the approach here is going to be superseded by #13480 and follow-up PRs. I may end up just closing this PR out once all the auth and metrics work has been split out. |
Leaving a note here that much of this code has been pulled out into pre-forwarding authentication and RPC rate metrics work planned to ship in Nomad 1.5.0. Once that work is done I'll rebase this on main and start over on any actual limiting. |
Provide re-auth rate limiting at the Nomad servers, with the ability to observe
which users are creating the load.
Note to reviewers: this is a really chonky PR so I've broken it up into commits that can be reviewed individually:
RPCContext
into all the RPC endpoints (+300/-100 line diff)I still need to do some more E2E testing of this PR but I wanted to get some reviewers of it so that we can pick up any remaining design or UX flaws in parallel.
cc @schmichael @jrasell @mikenomitch (ref RFC NMD-148)