WIP: Secure Variables: Go API #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
angrycub
commented
Jun 27, 2022
•
angrycub
commented
- SV API: Go API
- Fix Testutil for delve debugging API tests
- Updates to API
- SV: Go API: Working state
angrycub
added
theme/api
tgross
approved these changes
Jun 28, 2022
Comment on lines
67
to
71
| // delve debug executable for debugging test | ||
| case strings.HasSuffix(path, "__debug_bin"): | ||
| return false | ||
| case strings.HasSuffix(path, "__debug_bin.exe"): | ||
| return false |
api/api.go
Outdated
Comment on lines
1131
to
1137
| // closeResponseBody reads resp.Body until EOF, and then closes it. The read | ||
| // is necessary to ensure that the http.Client's underlying RoundTripper is able | ||
| // to re-use the TCP connection. See godoc on net/http.Client.Do. | ||
| func closeResponseBody(resp *http.Response) error { | ||
| _, _ = io.Copy(ioutil.Discard, resp.Body) | ||
| return resp.Body.Close() | ||
| } |
There was a problem hiding this comment.
This seems like a bug fix? Should we open a new PR with just this to fix the existing usage for backport as well?
api/secure_variables.go
Outdated
Comment on lines
76
to
97
| // CheckedUpdate is used to updated a secure variable if the modify index | ||
| // matches the one on the server | ||
| func (sv *SecureVariables) CheckedUpdate(v *SecureVariable, qo *WriteOptions) (*WriteMeta, error) { |
There was a problem hiding this comment.
I like the API split between checked and unchecked you've done here. It's much nicer than passing some random checked bool flag or foisting the problem off on the consumer.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.