Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling createTime and modifyTime through serialization now that they contain nanoseconds #13620

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

philrenaud
Copy link
Contributor

Otherwise, we'd get an unmarshall error on save, and/or an invalid date on tables in the UI.

@philrenaud philrenaud self-assigned this Jul 6, 2022
@philrenaud philrenaud marked this pull request as ready for review July 6, 2022 17:23
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Ember Asset Size action

As of da2ded8

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +104 B +15 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

suggestion: Whenever, I'm trying assert that the request I'm sending to the server is formatted correctly, I'll write a test case like this (below) to ensure this doesn't turn into a bug later on:

server.get('/someEndPoint', function (_server, fakeRequest) {
        assert.deepEqual(
          fakeRequest.queryParams,
          {
            someProperty: 'someValue',
          },
          'It makes another server request using the options selected by the user'
        );
        return [];
      });

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Ember Test Audit comparison

secure-variables da2ded8 change
passes 1371 1371 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit ba3451d into secure-variables Jul 6, 2022
@philrenaud philrenaud deleted the handle-nano-times-for-vars branch July 6, 2022 18:17
tgross pushed a commit that referenced this pull request Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants