Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: enforce max_kill_timeout client configuration #13626

Merged
merged 1 commit into from
Jul 7, 2022
Merged

client: enforce max_kill_timeout client configuration #13626

merged 1 commit into from
Jul 7, 2022

Commits on Jul 6, 2022

  1. client: enforce max_kill_timeout client configuration 

    This PR fixes a bug where client configuration max_kill_timeout was
not being enforced. The feature was introduced in 9f44780 but seems
to have been removed during the major drivers refactoring.

We can make sure the value is enforced by pluming it through the DriverHandler,
which now uses the lesser of the task.killTimeout or client.maxKillTimeout.
Also updates Event.SetKillTimeout to require both the task.killTimeout and
client.maxKillTimeout so that we don't make the mistake of using the wrong
value - as it was being given only the task.killTimeout before.
    @shoenig
    shoenig committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    dbcccc7 View commit details
    Browse the repository at this point in the history