Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of driver/docker: Don't pull InfraImage if it exists into release/1.3.x #13636

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13265 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


This PR tweaks the behavior of Nomad's Docker driver during network setup.

When Nomad sets up a new Docker network, it establishes the network namespace by running a "no-op" container, internally called InfraImage. By default the container's image is gcr.io/google_containers/pause-amd64:3.1 (where amd64 is the GOARCH).

Every time a network is set up, that container image is pulled from the Google Container Registry (or alternate image, if configured). In a cluster with a high rate of Nomad job creation, the Docker pull is seen to intermittently fail (about 0.4%), perhaps due to rate limiting or normal transient network problems.

Because this image is versioned (tagged 3.1, currently), it is not necessary to run a Docker pull on every use. This PR proposes a refinement to the Docker driver's CreateNetwork function to first check if the image is present locally before pulling it. The expectation is to improve resiliency of Nomad job launches, and to remove a bit of excess load from GCR (or other configured registry).

Fixes #11014
Fixes #11380
Fixes #10318

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/tbehling/avoid-pull-infra-image/namely-solid-bengal branch from 91336cc to 3ba9025 Compare July 7, 2022 15:44
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 5fcefde into release/1.3.x Jul 7, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/tbehling/avoid-pull-infra-image/namely-solid-bengal branch July 7, 2022 15:44
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants