Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: upserting key metadata in FSM must be deterministic #13733

Merged
merged 1 commit into from
Jul 14, 2022
Merged

keyring: upserting key metadata in FSM must be deterministic #13733

merged 1 commit into from
Jul 14, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 13, 2022 •
edited
Loading

Fixes #13725 for the secure variables keyring. This hasn't shipped in a release of Nomad, so that's why it's in its own PR with no changelog.

@tgross tgross added this to the 1.4.0 milestone Jul 13, 2022
@tgross tgross added theme/variables Variables feature type/bug labels Jul 13, 2022
@tgross tgross mentioned this pull request Jul 13, 2022
Merged
schmichael
schmichael approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like NewRootKey was already setting this via leader.go:initializeKeyring and the Rotate RPC? If so 👍

@tgross tgross merged commit 3636340 into main Jul 14, 2022
@tgross tgross deleted the keyring-fsm-determinism branch July 14, 2022 12:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@angrycub angrycub Awaiting requested review from angrycub

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees
No one assigned
Labels
theme/variables Variables feature type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross @schmichael