Backport of metrics: classless blocked evals get metrics into release/1.2.x #13806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shoenig
force-pushed
the
backport/b-metrics-for-classless-blocked-evals/marginally-vital-bass
branch
from
435e94c
to
f44412d
Compare
This PR fixes a bug where blocked evaluations with no class set would not have metrics exported at the dc:class scope. Fixes #13759
shoenig
force-pushed
the
backport/b-metrics-for-classless-blocked-evals/marginally-vital-bass
branch
from
f44412d
to
b8b48c1
Compare
shoenig
deleted the
backport/b-metrics-for-classless-blocked-evals/marginally-vital-bass
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13786 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR fixes a bug where blocked evaluations with no class set would
not have metrics exported at the
dc:classscope.Fixes #13759
Also drive-by fixup naming of
ByNodetoByClassInDCwhich is more accurate 🤦Backport to 1.3.x, 1.2.x