Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder the select boxes on evals so namespaces are first #13866

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Reorder the select boxes on evals so namespaces are first #13866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d3308
Reorder the select boxes on evals so namespaces are first
philrenaud Jul 20, 2022
70c5f0f
Wrap evals buttons in a button-bar for consistent styling and spacing
philrenaud Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 30 additions & 28 deletions ui/app/templates/evaluations/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,34 +11,36 @@
/>
</div>
<div class="toolbar-item is-right-aligned">
<SingleSelectDropdown
data-test-evaluation-status-facet
@label="Status"
@options={{this.optionsEvaluationsStatus}}
@selection={{this.status}}
@onSelect={{action this.setQueryParam "status"}}
/>
<SingleSelectDropdown
data-test-evaluation-triggered-by-facet
@label="Triggered By"
@options={{this.optionsTriggeredBy}}
@selection={{this.triggeredBy}}
@onSelect={{action this.setQueryParam "triggeredBy"}}
/>
<SingleSelectDropdown
data-test-evaluation-type-facet
@label="Type"
@options={{this.optionsType}}
@selection={{this.type}}
@onSelect={{action this.setQueryParam "type"}}
/>
<SingleSelectDropdown
data-test-evaluation-namespace-facet
@label="Namespace"
@options={{this.optionsNamespaces}}
@selection={{this.qpNamespace}}
@onSelect={{action this.setQueryParam "qpNamespace"}}
/>
<div class="button-bar">
<SingleSelectDropdown
data-test-evaluation-namespace-facet
@label="Namespace"
@options={{this.optionsNamespaces}}
@selection={{this.qpNamespace}}
@onSelect={{action this.setQueryParam "qpNamespace"}}
/>
<SingleSelectDropdown
data-test-evaluation-status-facet
@label="Status"
@options={{this.optionsEvaluationsStatus}}
@selection={{this.status}}
@onSelect={{action this.setQueryParam "status"}}
/>
<SingleSelectDropdown
data-test-evaluation-triggered-by-facet
@label="Triggered By"
@options={{this.optionsTriggeredBy}}
@selection={{this.triggeredBy}}
@onSelect={{action this.setQueryParam "triggeredBy"}}
/>
<SingleSelectDropdown
data-test-evaluation-type-facet
@label="Type"
@options={{this.optionsType}}
@selection={{this.type}}
@onSelect={{action this.setQueryParam "type"}}
/>
</div>
</div>
</div>
<div class="table-container">
Expand Down