core: add ACL role state schema and functionality. #13955
Conversation
jrasell
force-pushed
the
f-gh-13120-acl-role-core-state
branch
from
44bc65e
to
9107b63
Compare
jrasell
force-pushed
the
f-gh-13120-acl-role-core-state
branch
from
9107b63
to
7ee6f9a
Compare
jrasell
force-pushed
the
f-gh-13120-acl-role-core-state
branch
from
7ee6f9a
to
9f24ae3
Compare
This commit includes the new state schema for ACL roles along with state interaction functions for CRUD actions. The change also includes snapshot persist and restore functionality and the addition of FSM messages for Raft updates which will come via RPC endpoints.
jrasell
force-pushed
the
f-gh-13120-acl-role-core-state
branch
from
9f24ae3
to
7a1e05f
Compare
| // Ensure the role hash is not zero to provide defense in depth. This | ||
| // should be done outside the state store, so we do not spend time here | ||
| // and thus Raft, when it, can be avoided. | ||
| if len(role.Hash) == 0 { | ||
| role.SetHash() | ||
| } |
There was a problem hiding this comment.
Just rambling, but I wish in retrospect the objects that have these Hash values were made from constructors or a factory or something - enforcing the hash to be set on creation rather than by hand
There was a problem hiding this comment.
That is a good shout. I will merge this PR as is to unblock some additional PR that are lined up, but will look into this approach as a follow up item.
| if len(a.Hash) == 0 { | ||
| a.SetHash() | ||
| } |
There was a problem hiding this comment.
More rambling: one thing we could do is split SetHash into
SetHash- only set the hash if the length is zeroResetHashalways sets the hash to updated values
And that way we can avoid wrapping calls to SetHash with the length check in all the places where we do that
There was a problem hiding this comment.
I like the approach and with the above i'll take a look into this as a follow up to enhance the hash setting and raise a followup to look into similar for other structs.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This commit includes the new state schema for ACL roles along with
state interaction functions for CRUD actions.
The change also includes snapshot persist and restore
functionality and the addition of FSM messages for Raft updates
which will come via RPC endpoints.
related: #13120
targets: feature branch