Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: reduce monitor socket path #13971

Merged
merged 3 commits into from
Aug 4, 2022
Merged

qemu: reduce monitor socket path #13971

merged 3 commits into from
Aug 4, 2022

Commits on Aug 4, 2022

  1. qemu: reduce monitor socket path file name 

    The QEMU driver can take an optional `graceful_shutdown` configuration
which will create a Unix socket to send ACPI shutdown signal to the VM.

Unix sockets have a hard length limit and the driver implementation
assumed that QEMU versions 2.10.1 were able to handle longer paths. This
is not correct, the linked QEMU fix only changed the behaviour from
silently truncating longer socket paths to throwing an error.

By validating the socket path before starting the QEMU machine we can
provide users a more actionable and meaningful error message, and by
using a shorter socket file name we leave a bit more room for
user-defined values in the path, such as the task name.

The maximum length allowed is also platform-dependant, so validation
needs to be different for each OS.
    @lgfa29
    lgfa29 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    620c090 View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #13971

    @lgfa29
    lgfa29 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    06d9261 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @lgfa29
    lgfa29 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2478ad5 View commit details
    Browse the repository at this point in the history