Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ui: fix zero memory utilization bug on systems using cgroups v2 into release/1.3.x #13990

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13670 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


A quick band-aid fix for #13023. On systems using cgroups v2, the MemoryStats struct no longer reports .RSS, but rather .Usage. Kind of just assuming they mean the same thing.

The fix here is to just check if .Usage exists and if so use that, otherwise fallback to the .RSS field.

"MemoryStats": {
	"RSS": 0,
	"Cache": 0,
	"Swap": 0,
	"MappedFile": 0,
	"Usage": 98656256,
	"MaxUsage": 0,
	"KernelUsage": 0,
	"KernelMaxUsage": 0,
	"Measured": [
		"Cache",
		"Swap",
		"Usage"
	]
},

@philrenaud @ChaiWithJai

Fixes #13023

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/ui-memory-cgroupsv2/rightly-suited-albacore branch from f6d01a0 to 150075c Compare August 3, 2022 18:19
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 767d47b into release/1.3.x Aug 3, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/ui-memory-cgroupsv2/rightly-suited-albacore branch August 3, 2022 18:19
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Ember Test Audit comparison

release/1.3.x 150075c change
passes 1286 1286 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants