UI variables made to be unique by namespace and path #14072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of cb9f34a Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on ca98396:
|
ChaiWithJai
reviewed
Aug 12, 2022
ChaiWithJai
suggested changes
Aug 12, 2022
ui/app/routes/variables/variable.js
Outdated
| @@ -8,8 +8,9 @@ export default class VariablesVariableRoute extends Route.extend( | |||
| ) { | |||
| @service store; | |||
| model(params) { | |||
| // console.log('paramas', params, this.store.findAll('variable')); | |||
ChaiWithJai
reviewed
Aug 12, 2022
ChaiWithJai
approved these changes
Aug 12, 2022
ui/app/routes/variables/variable.js
Outdated
| @@ -8,8 +8,9 @@ export default class VariablesVariableRoute extends Route.extend( | |||
| ) { | |||
| @service store; | |||
| model(params) { | |||
| // console.log('paramas', params, this.store.findAll('variable')); | |||
…ess (#14098) * Solves a harsh bug where you have namespace access but no secvars access * Lint cleanup * Remove unneeded condition
philrenaud
deleted the
14066-ui-variables-should-be-unique-by-namespace-and-path
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14066, #13950 and #14066
Adds namespaces to the stored identity of variables.
This means you can have multiple variables at
a/b/c/foo0if their namespaces are different.IDs are now stored in the browser as
<pathname>@<namespace>, ora/b/c/foo0@defaultin the above case, and URLs reflect this:Note that we now display same-pathed, different-namespaced variables alongside one another:
