Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add new acl role subcommands for CRUD role actions. #14087

Merged
merged 2 commits into from
Aug 12, 2022
Merged

cli: add new acl role subcommands for CRUD role actions. #14087

merged 2 commits into from
Aug 12, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 11, 2022

related: #13120
targets: feature branch

@jrasell jrasell added this to the 1.4.0 milestone Aug 11, 2022
@jrasell jrasell self-assigned this Aug 11, 2022
DerekStrickland
DerekStrickland approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! No blockers. Some suggestions around comments.

command/acl_role_create.go Show resolved Hide resolved
command/acl_role_create.go Outdated Show resolved Hide resolved
command/acl_role_info_test.go Outdated Show resolved Hide resolved
command/acl_role_update.go Show resolved Hide resolved
command/acl_role_update_test.go Show resolved Hide resolved
@jrasell @DerekStrickland
Apply suggestions from code review
8412eb7 
Co-authored-by: Derek Strickland <1111455+DerekStrickland@users.noreply.github.com>
@jrasell jrasell merged commit ff798dc into f-gh-13120-sso-umbrella Aug 12, 2022
@jrasell jrasell deleted the f-gh-13120-acl-role-cli branch August 12, 2022 07:52
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DerekStrickland DerekStrickland DerekStrickland approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrasell @DerekStrickland