ACL: disallow missing path in secure variable policy
#14123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HCL parser allows for labels that aren't needed, which makes it easy to accidentally write a `secure_variable` block that has the intended path as the label for that block instead of the innner `path` block. This can result in silent failure to lock down variables if an incorrectly specified block was used to reduce the scope of capabilities (for example, if another correctly-written rule allows access to `*`). We can't detect the extraneous label in the HCL API, but we can detect if we're missing `path` blocks entirely. Use this to block obvious user errors.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14038
The HCL parser allows for labels that aren't needed, which makes it easy to
accidentally write a
secure_variableblock that has the intended path as thelabel for that block instead of the innner
pathblock. This can result insilent failure to lock down variables if an incorrectly specified block was used
to reduce the scope of capabilities (for example, if another correctly-written
rule allows access to
*).We can't detect the extraneous label in the HCL API, but we can detect if we're
missing
pathblocks entirely. Use this to block obvious user errors.