-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: conditional checks for token secret before fetch #14134
Conversation
Ember Asset Size actionAs of 21edd00 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChaiWithJai I'm not entirely sure if this fixes the bug described in #13847. Starting without a token (incognito window) I no longer see the requests to /v1/acl/token/self
in the agent logs, but when I click on any of the links on the page, including the link to /ui/settings/tokens
, the URL bar is updated but the page is not:
I don't see any HTTP requests hit the agent either (or in the Chrome Tools network tab for that matter).
Ember Test Audit comparison
|
Just leaving a note that my issue above is unrelated to this PR and will be fixed by #14144, which @ChaiWithJai and @philrenaud helped me hack on 😀 |
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on 21edd00:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Visiting the web UI without a token set, I now only see the following logs as expected:
2022-08-17T13:02:34.613Z [DEBUG] http: request complete: method=GET path=/v1/agent/health?type=client duration="169.429µs"
2022-08-17T13:02:35.436Z [DEBUG] http: request failed: method=GET path=/v1/acl/policy/anonymous error="ACL policy not found" code=404
2022-08-17T13:02:35.436Z [DEBUG] http: request complete: method=GET path=/v1/acl/policy/anonymous duration=5.234403ms
2022-08-17T13:02:35.485Z [DEBUG] http: request failed: method=GET path=/v1/jobs? error="Permission denied" code=403
2022-08-17T13:02:35.494Z [DEBUG] http: request complete: method=GET path=/v1/jobs? duration=16.637132ms
2022-08-17T13:02:35.493Z [DEBUG] http: request complete: method=GET path=/v1/namespaces duration=4.510974ms
2022-08-17T13:02:35.640Z [DEBUG] http: request failed: method=GET path="/v1/jobs?&index=1" error="Permission denied" code=403
2022-08-17T13:02:35.641Z [DEBUG] http: request complete: method=GET path="/v1/jobs?&index=1" duration="395.122µs"
2022-08-17T13:02:35.681Z [DEBUG] http: request complete: method=GET path=/v1/namespaces duration="600.458µs"
2022-08-17T13:02:36.176Z [DEBUG] http: request complete: method=GET path=/v1/agent/health?type=server duration="162.15µs"
2022-08-17T13:02:44.615Z [DEBUG] http: request complete: method=GET path=/v1/agent/health?type
)" This reverts commit b9fec22.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes 13847