Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: make listing RPC and HTTP API a stub return object. #14211

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 22, 2022

Making the ACL Role listing return object a stub future-proofs the
endpoint. In the event the role object grows, we are not bound by
having to return all fields within the list endpoint or change the
signature of the endpoint to reduce the list return size.

related: #13120
targets: feature branch

@jrasell jrasell added this to the 1.4.0 milestone Aug 22, 2022
@jrasell jrasell requested review from shoenig and lgfa29 August 22, 2022 09:11
@jrasell jrasell self-assigned this Aug 22, 2022
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just the one question about Hash in api/

api/acl.go Outdated Show resolved Hide resolved
Making the ACL Role listing return object a stub future-proofs the
endpoint. In the event the role object grows, we are not bound by
having to return all fields within the list endpoint or change the
signature of the endpoint to reduce the list return size.
@jrasell jrasell force-pushed the f-gh-13120-role-list-use-stub branch from 7d95b55 to 3a4c1bf Compare August 22, 2022 14:49
@jrasell jrasell merged commit 4be6de2 into f-gh-13120-sso-umbrella Aug 22, 2022
@jrasell jrasell deleted the f-gh-13120-role-list-use-stub branch August 22, 2022 15:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants