Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: use task state to determine if task is active #14224

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Commits on Aug 22, 2022

  1. ui: use task state to determine if task is active

    The current implementation uses the task's finishedAt field to determine
    if a task is active of not, but this check is not accurate. A task in
    the "pending" state will not have finishedAt value but it's also not
    active.
    
    This discrepancy results in some components, like the inline stats chart
    of the task row component, to be displayed even whey they shouldn't.
    lgfa29 committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    72e7c81 View commit details
    Browse the repository at this point in the history
  2. changelog: add entry for #14224

    lgfa29 committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1542604 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. ui: fix tests for active tasks

    lgfa29 committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    434ee99 View commit details
    Browse the repository at this point in the history