Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: allow tokens to lookup linked roles. #14227

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 23, 2022

When listing or reading an ACL role, roles linked to the ACL token
used for authentication can be returned to the caller.

I looked into using go-set for the allowed logic within the handler,
the requirement for creating the set, then transforming it meant it
was not suitable.

related: #13120
targets: feature branch

@jrasell jrasell added this to the 1.4.0 milestone Aug 23, 2022
@jrasell jrasell self-assigned this Aug 23, 2022
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just optional code golfing

nomad/acl_endpoint.go Outdated Show resolved Hide resolved
nomad/acl_endpoint.go Outdated Show resolved Hide resolved
When listing or reading an ACL role, roles linked to the ACL token
used for authentication can be returned to the caller.
@jrasell jrasell force-pushed the f-gh-13120-allow-own-role-lookup branch from 27ec682 to 23e949a Compare August 24, 2022 11:14
@jrasell jrasell merged commit f4db3b6 into f-gh-13120-sso-umbrella Aug 24, 2022
@jrasell jrasell deleted the f-gh-13120-allow-own-role-lookup branch August 24, 2022 11:51
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants