Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ui: use task state to determine if task is active into release/1.3.x #14263

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14224 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


The current implementation uses the task's finishedAt field to determine
if a task is active of not, but this check is not accurate. A task in
the "pending" state will not have finishedAt value but it's also not
active.

This discrepancy results in some components, like the inline stats chart
of the task row component, to be displayed even whey they shouldn't.

@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 59c0059 into release/1.3.x Aug 23, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/ui-fix-task-state/purely-wanted-bluebird branch August 23, 2022 22:00
@github-actions
Copy link

Ember Test Audit comparison

release/1.3.x b835eff change
passes 1301 1301 0
failures 0 0 0
flaky 0 0 0
duration 9m 30s 114ms 9m 51s 288ms +21s 174ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants