Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of client/logmon: acquire executable in init block into release/1.2.x #14303

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14297 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


This PR causes the logmon task runner to acquire the path of binary of the
Nomad executable file in an init block, so as to almost certainly acquire
the name while the nomad file still exists.

This is an attempt at fixing the case where a deleted Nomad file
(e.g. during upgrade) may be getting renamed with a suffix before the deletion
(maybe SELinux specific?).

If this doesn't work, as a last resort we can literally just trim the mystery string.

Fixes: #14079

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-logmon-fork-mystery-bin/endlessly-meet-shad branch from 10fe6f9 to 71cf138 Compare August 24, 2022 20:25
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 289526e into release/1.2.x Aug 24, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-logmon-fork-mystery-bin/endlessly-meet-shad branch August 24, 2022 20:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants