Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of vault: detect namespace change in config reload into release/1.2.x #14309

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14298 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


The namespace field was not included in the equality check between old and new
Vault configurations, which meant that a Vault config change that only changed
the namespace would not be detected as a change and the clients would not be
reloaded.

Also, the comparison for boolean fields such as enabled and
allow_unauthenticated was on the pointer and not the value of that pointer,
which results in spurious reloads in real config reload that is easily missed in
typical test scenarios.

Includes a minor refactor of the order of fields for Copy and Merge to match
the struct fields in hopes it makes it harder to make this mistake in the
future, as well as additional test coverage.


This comes out of #14233 but doesn't fix it as far as I can tell.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-vault-unsupported-path/rapidly-noble-snail branch from ec7a6aa to 70f71fd Compare August 24, 2022 21:03
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 8ccda9f into release/1.2.x Aug 24, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-vault-unsupported-path/rapidly-noble-snail branch August 24, 2022 21:03
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants