Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ui: task lifecycle restart all tasks into release/1.3.x #14317

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14223 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


This PR adds the option to restart all tasks in an allocation and fixes a CSS rule that was defined by a task finishedAt value. Since tasks that finished running can now be restarted, this check caused the lifecycle element to be rendered with the wrong class.

After/Before:
image

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/task-lifecycle-restart-ui/curiously-useful-hen branch from 6c23186 to 4f11317 Compare August 24, 2022 22:44
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit e46c36b into release/1.3.x Aug 24, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/task-lifecycle-restart-ui/curiously-useful-hen branch August 24, 2022 22:44
@github-actions
Copy link

Ember Test Audit comparison

release/1.3.x 4f11317 change
passes 1301 1301 0
failures 0 0 0
flaky 0 0 0
duration 10m 45s 611ms 11m 49s 019ms +1m 03s 408ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants