ui: long poll /checks endpoint
#14354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of c48d50b Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
philrenaud
approved these changes
Aug 26, 2022
Ember Test Audit comparison
|
philrenaud
pushed a commit
that referenced
this pull request
Aug 31, 2022
* chore: add lodash isEqual package * ui: fetch non ember-data records * ui: create watcher to poll non ember-data records
philrenaud
pushed a commit
that referenced
this pull request
Sep 7, 2022
* chore: add lodash isEqual package * ui: fetch non ember-data records * ui: create watcher to poll non ember-data records
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles long polling the
client/allocations/:allocId/checksendpoint which is not stored in Ember Data. Instead we add the property directly onto theAllocationto visualize the Service Health information in real-time.When doing real-time visualizations, we follow a pattern of skipping the Ember Data store because we expect a clean slate on every fetch.