Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of consul: allow stale namespace results into release/1.2.x #14357

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Backport of consul: allow stale namespace results into release/1.2.x #14357

merged 2 commits into from
Aug 26, 2022

Commits on Aug 26, 2022

  1. no-op commit due to failed cherry-picking

    temp committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    8b8e200 View commit details
    Browse the repository at this point in the history

  2. consul: allow stale namespace results 

    Nomad reconciles services it expects to be registered in Consul with
what is actually registered in the local Consul agent. This is necessary
to prevent leaking service registrations if Nomad crashes at certain
points (or if there are bugs).

When Consul has namespaces enabled, we must iterate over each available
namespace to be sure no services were leaked into non-default
namespaces.

Since this reconciliation happens often, there's no need to require
results from the Consul leader server. In large clusters this creates
far more load than the "freshness" of the response is worth.

Therefore this patch switches the request to AllowStale=true
    @schmichael
    schmichael committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6d9883f View commit details
    Browse the repository at this point in the history