-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Service Discovery: Allocation Service fly-out #14389
[ui] Service Discovery: Allocation Service fly-out #14389
Conversation
Ember Asset Size actionAs of 3780255 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
$topNavOffset: 112px; | ||
$subNavOffset: 49px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making these variables to avoid magic-number syndrome
ui/app/serializers/task-group.js
Outdated
if (hash.Services) { | ||
hash.Services.forEach((service) => { | ||
service.GroupName = hash.Name; | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed in the task serializer, as services there already get populated with TaskName
props.
50aef45
to
01a8c94
Compare
59f87e8
to
d6edccf
Compare
d6edccf
to
8e6bbd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Bones of a new flyout section * Basic sidebar behaviour and style edits * Concept of a refID for service fragments to disambiguate task and group * A11y audit etc * Moves health check aggregation to serviceFragment model and retains history * Has to be a getter * flyout populated * Sidebar styling * Sidebar table and details added * Mirage fixture * Active status and table styles * Unit test mock updated * Acceptance tests for alloc services table and flyout * Chart styles closer to mock * Without a paused test * Consul and Nomad icons in services table * Alloc services test updates in light of new column changes * without using an inherited scenario
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
resolves #14386
Establishes a
sidebar
component with queryParam persistence.Side-effect
refID
to service fragments for easier lookup. They already have aTaskName
property, and added aGroupName
property as well.