[ui] Service Discovery: Allocation Service fly-out #14389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 3780255 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
philrenaud
changed the title
philrenaud
commented
Aug 30, 2022
Comment on lines
+1
to
+2
| $topNavOffset: 112px; | ||
| $subNavOffset: 49px; |
There was a problem hiding this comment.
Making these variables to avoid magic-number syndrome
philrenaud
commented
Aug 30, 2022
ui/app/serializers/task-group.js
Outdated
Comment on lines
11
to
15
| if (hash.Services) { | ||
| hash.Services.forEach((service) => { | ||
| service.GroupName = hash.Name; | ||
| }); | ||
| } |
There was a problem hiding this comment.
not needed in the task serializer, as services there already get populated with TaskName props.
philrenaud
force-pushed
the
f-ui/service-discovery
branch
from
50aef45
to
01a8c94
Compare
philrenaud
force-pushed
the
14386-ui-service-discovery-service-fly-out-detail-view
branch
from
59f87e8
to
d6edccf
Compare
philrenaud
force-pushed
the
14386-ui-service-discovery-service-fly-out-detail-view
branch
from
d6edccf
to
8e6bbd3
Compare
ChaiWithJai
approved these changes
Aug 31, 2022
philrenaud
deleted the
14386-ui-service-discovery-service-fly-out-detail-view
branch
philrenaud
added a commit
that referenced
this pull request
Sep 7, 2022
* Bones of a new flyout section * Basic sidebar behaviour and style edits * Concept of a refID for service fragments to disambiguate task and group * A11y audit etc * Moves health check aggregation to serviceFragment model and retains history * Has to be a getter * flyout populated * Sidebar styling * Sidebar table and details added * Mirage fixture * Active status and table styles * Unit test mock updated * Acceptance tests for alloc services table and flyout * Chart styles closer to mock * Without a paused test * Consul and Nomad icons in services table * Alloc services test updates in light of new column changes * without using an inherited scenario
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14386
Establishes a
sidebarcomponent with queryParam persistence.Side-effect
refIDto service fragments for easier lookup. They already have aTaskNameproperty, and added aGroupNameproperty as well.