Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix TestNomad_BootstrapExpect_NonVoter test #14407

Merged
merged 2 commits into from
Aug 30, 2022
Merged

ci: fix TestNomad_BootstrapExpect_NonVoter test #14407

merged 2 commits into from
Aug 30, 2022

Commits on Aug 30, 2022

  1. ci: fix TestNomad_BootstrapExpect_NonVoter test 

    PR #12130 refactored the test to use the `wantPeers` helper, but this
function only returns the number of voting peers, which in this test
should be equal to 2.

I think the tests were passing back them because of a bug in Raft
(hashicorp/raft#483) where a non-voting server
was able to transition to candidate state.

One possible evidence of this is that a successful test run would have
the following log line:

```
raft@v1.3.5/raft.go:1058: nomad.raft: updating configuration: command=AddVoter server-id=127.0.0.1:9101 server-addr=127.0.0.1:9101 servers="[{Suffrage:Voter ID:127.0.0.1:9107 Address:127.0.0.1:9107} {Suffrage:Voter ID:127.0.0.1:9105 Address:127.0.0.1:9105} {Suffrage:Voter ID:127.0.0.1:9103 Address:127.0.0.1:9103} {Suffrage:Voter ID:127.0.0.1:9101 Address:127.0.0.1:9101}]"
```

This commit reverts the test logic to check for peer count, regardless
of voting status.
    @lgfa29
    lgfa29 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    96707c5 View commit details
    Browse the repository at this point in the history

  2. test: fix server join order

    @lgfa29
    lgfa29 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    d605f72 View commit details
    Browse the repository at this point in the history