-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Jobs/jobid/services table sorting #14410
[ui] Jobs/jobid/services table sorting #14410
Conversation
Ember Asset Size actionAs of b64102d Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! but how does this forward query parameters when we make the network request? did we already handle that behavior?
50aef45
to
01a8c94
Compare
adc50e3
to
b64102d
Compare
Sorting and filtering job services is not supported as part of our API, per https://www.nomadproject.io/api-docs/jobs#job-services, so all this PR seeks to do is handle it within the UI. |
* Sortable job service table * sorting removed from specific service page
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #14387
Implements sorting on the Services table, and makes a style adjustment to move provider icon inline next to service name