Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Jobs/jobid/services table sorting #14410

Merged

Conversation

philrenaud
Copy link
Contributor

Resolves #14387

Implements sorting on the Services table, and makes a style adjustment to move provider icon inline next to service name

@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Ember Asset Size action

As of b64102d

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +182 B +14 B
nomad-ui.css +64 B +14 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Ember Test Audit comparison

f-ui/service-discovery b64102d change
passes 1425 1425 0
failures 0 0 0
flaky 0 0 0
duration 11m 31s 211ms 10m 02s 758ms -1m 28s 453ms

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! but how does this forward query parameters when we make the network request? did we already handle that behavior?

@philrenaud
Copy link
Contributor Author

great! but how does this forward query parameters when we make the network request? did we already handle that behavior?

Sorting and filtering job services is not supported as part of our API, per https://www.nomadproject.io/api-docs/jobs#job-services, so all this PR seeks to do is handle it within the UI.

@philrenaud philrenaud merged commit 3260c6f into f-ui/service-discovery Aug 31, 2022
@philrenaud philrenaud deleted the 14387-ui-service-discovery-table-sorting branch August 31, 2022 14:50
philrenaud added a commit that referenced this pull request Sep 7, 2022
* Sortable job service table

* sorting removed from specific service page
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants