ui: only long poll /checks endpoint when route is active
#14472
Conversation
| @@ -48,5 +48,5 @@ export default class AllocationRoute extends Route.extend(WithWatchers) { | |||
| @watchRecord('allocation') watch; | |||
| @watchNonStoreRecords('allocation') watchHealthChecks; | |||
|
|
|||
| @collect('watch') watchers; | |||
| @collect('watch', 'watchHealthChecks') watchers; | |||
There was a problem hiding this comment.
Does this work because watchers are subject to visibilityHandler() ?
There was a problem hiding this comment.
Does this work because watchers are subject to visibilityHandler() ?
No, that's not the reason. Checkout with-watchers and you'll notice a computed property called watchers. When we have multiple watchers in a controller, we need to set the watchers property by following this pattern.
cancellAllWatchers iterates over watchers and cancels each of them. Because we weren't adding watchHealthChecks to the collection we weren't canceling this request we weren't canceling it.
Ember Asset Size actionAs of 031c4e9 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes 14471.