Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval broker: shed all but one blocked eval per job after ack #14621

Merged
merged 3 commits into from
Nov 16, 2022

Commits on Nov 9, 2022

  1. eval broker: shed all but one blocked eval per job after ack

    When an evaluation is acknowledged by a scheduler, the resulting plan is
    guaranteed to cover up to the `waitIndex` set by the worker based on the most
    recent evaluation for that job in the state store. At that point, we no longer
    need to retain blocked evaluations in the broker that are older than that index.
    
    Move all but the highest priority / highest `ModifyIndex` blocked eval into a
    canceled set. When the `Eval.Ack` RPC returns from the eval broker it will
    retrieve a batch of canceable evals to write to raft. This paces the
    cancelations limited by how frequently the schedulers are acknowledging evals;
    this should reduce the risk of cancelations from overwhelming raft relative to
    scheduler progress. In order to avoid straggling batches when the cluster is
    quiet, we also include a periodic sweep through the cancelable list.
    tgross committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    e372037 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Configuration menu
    Copy the full SHA
    5b7c8f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63e7389 View commit details
    Browse the repository at this point in the history