Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: provide more detail on ACL bootstrap request error #14629

Merged
merged 2 commits into from
Sep 21, 2022
Merged

api: provide more detail on ACL bootstrap request error #14629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fdc583
api: provide more detail on ACL bootstrap request error
lgfa29 Sep 20, 2022
99235ed
changelog: add entry for #14629
lgfa29 Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/14629.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
api: return a more descriptive error when /v1/acl/bootstrap fails to decode request body
```
3 changes: 2 additions & 1 deletion command/agent/acl_endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package agent

import (
"fmt"
"net/http"
"strings"

Expand Down Expand Up @@ -142,7 +143,7 @@ func (s *HTTPServer) ACLTokenBootstrap(resp http.ResponseWriter, req *http.Reque

if req.ContentLength != 0 {
if err := decodeBody(req, &args); err != nil {
return nil, CodedError(400, err.Error())
return nil, CodedError(400, fmt.Sprintf("failed to decode request body: %s", err))
}
}

Expand Down