Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e for non-overlapping placements #14646

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

schmichael
Copy link
Member

Followup to #10446

Fails (as expected) against 1.3.x at the wait for blocked eval (because the allocs are allowed to overlap).

Passes against 1.4.0-beta.1 (as expected).

Followup to #10446

Fails (as expected) against 1.3.x at the wait for blocked eval (because
the allocs are allowed to overlap).

Passes against 1.4.0-beta.1 (as expected).
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Two optional inline suggestions; it seems standard to also use input as the directory name that holds test jobs, again this is very optional nit-pick.

e2e/overlap/overlap_test.go Outdated Show resolved Hide resolved
e2e/overlap/overlap_test.go Outdated Show resolved Hide resolved
schmichael and others added 2 commits September 22, 2022 09:46
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
@schmichael
Copy link
Member Author

Two optional inline suggestions; it seems standard to also use input as the directory name that holds test jobs, again this is very optional nit-pick.

Ah yeah, forgot that:

$ find e2e -type d -name input | wc -l
30
$ find e2e -type d -name testdata | wc -l
3

I'd kind of like to start using testdata since it appears we're trying to move e2e tests closer to "normal" go tests (or at least that was my impression from looking at #14598) since testdata is the standard for inputs.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants